Request for Funding @scilio (CoinSwap Implementation)

scilio · November 11, 2021, 8:03am

Milestone 1 is just about complete. I just have a bit of error handling left and some documentation to write. If someone could create a mwixnet repo in the mimblewimble github org, I’ll be able to create a pull request for everyone to review.

oryhp · November 11, 2021, 10:05am

Repository created GitHub - mimblewimble/mwixnet: Implementation of the Mimblewimble CoinSwap proposal.

scilio · November 13, 2021, 4:26am

Thank you. I’ve created the pull request.

mcm-mike · November 13, 2021, 10:08am

I think we need to come up now with a review process in order to accept the first PR.
Great work and now we need a community effort to review the PR.

Who would be able to review it?
@tromp @joltz @davidtavarez

joltz · November 13, 2021, 3:14pm

I will do my best to give it a review this week.

First I need to familiarize myself with the protocol we are trying to implement. Is Mimblewimble CoinSwap proposal the completed specification or is there an updated one somewhere else?

scilio · November 13, 2021, 3:48pm

The code is based on that design, with some modifications documented in the README

github.com

scilio/mwixnet-1/blob/main/README.md

# MWixnet
This is an implementation of @tromp's [CoinSwap Proposal](https://forum.grin.mw/t/mimblewimble-coinswap-proposal/8322) with some slight modifications.

A set of n CoinSwap servers (node<sub>i</sub> with i=1...n) are agreed upon in advance. They each have a known public key.

### SWAP API
The first CoinSwap server (n<sub>1</sub>) provides the `swap` API, publicly available for use by GRIN wallets.

**jsonrpc:** `2.0`
**method:** `swap`
**params:**
```
[{
    "comsig": "000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f202122232425262728292a2b2c2d2e2f303132333435363738393a3b3c3d3e3f404142434445464748494a4b4c4d4e4f505152535455565758595a5b5c5d5e5f",
    "msg": "00010203",
    "onion": {
        "commit": "0967593792bc958cd73848c0b948ecab2c6e996ab3c550d462fe41359e447b651f",
        "data": ["3719e5fba260c71a5a4bcf9d9caa58cd5dc49531388782fae7699c6fa6b30b09fe42"],
        "pubkey": "020dd38a220280f14515f6901a3a366cb7b87630814e4b68b3189a32df964961e5"
    }

This file has been truncated. show original

oryhp · January 11, 2022, 3:54pm

@scilio could you give an update on the 18th Agenda: Community Council (CC), 18 January 2022 · Issue #33 · grincc/agenda · GitHub . If you’re unable to attend could you leave an update on the forum?

scilio · January 12, 2022, 3:45pm

Milestone 2 is nearing completion. So far, it

communicates with a GRIN node’s API using jsonrpc calls
validates input signatures using the new Commitment Signature scheme
verifies input commitments are in the UTXO set
executes round every DAY_HEIGHT (1440) blocks
verifies generated output commitments are not in the UTXO set
builds the kernel and assembles the transaction
submits the transaction to the node

For milestone 2, I still need to

add reorg support
improve fee handling & wallet support (could fall under milestone 3)
add better e2e tests

Trying to add support for handling reorgs efficiently has been the main challenge so far. I’m getting frustrated by the lack of progress, so may skip this and come back to it after the rest of milestone 2 is finished and merged.

My original time estimates were apparently too optimistic. Estimating software is hard. But don’t worry, I’m not going anywhere. I’ll try to give more frequent updates so everyone knows I’m still here.

satoshocrat · January 12, 2022, 4:27pm

Thank you for the diligence and excellence, Scilio.

oryhp · January 12, 2022, 4:47pm

Glad to hear that. I’ll take this opportunity to remind about some minor checks that would still need to be done about duplicate inputs/outputs which would stall the process that we left here for the next one.

Anynomous · February 17, 2022, 12:11am

@scilio I know you have been making some nice progress:
keybase://chat/grincoin.teams.wallet_dev#general/9472
How about a short bullet-point update here, so the community can show/like their appreciation for your efforts

readysalted · February 23, 2022, 11:34am

How’s the project going hax0rs need

Anynomous · April 22, 2022, 12:11pm

@scilio Any updates on the progress of the CoinSwap implementation?

scilio · April 27, 2022, 9:33pm

The (very) long overdue pull request for milestone 2 is now ready for review.

github.com/mimblewimble/mwixnet

Milestone 2

mimblewimble:main ← scilio:main

opened 01:37AM - 11 Feb 22 UTC

scilio

+5152 -1789

I unintentionally deviated from the [project plan](https://forum.grin.mw/t/reque…st-for-funding-scilio-coinswap-implementation/9149?u=scilio) somewhat. Milestone 2 was to contain: - 2a. Validation of all incoming data against a live node - 2b. Daily aggregation and broadcasting of the finalized transaction - 2c. Basic reorg protection - 2d. Automated e2e testing Milestone 3 was to contain: - 3a. Data provisioning using encrypted bundles - 3b. Inter-server communication - 3c. e2e tests that spin up local servers 1-n, demonstrating the workflow against a mock GRIN node --- (3a) was implemented in milestone 1 already, which I felt was necessary in order to design the best possible api. Also, to be sure the code was working correctly, I chose to implement (3c) for a single server in this pull request, without realizing it was part of milestone 3. Finally, to minimize the review complexity and avoid overwhelming reviewers, I chose not to include (2c) in this pull request. --- I'll work with the community council to handle these discrepancies from the PM side, but for review purposes, this PR contains: - 2a. Validation of all incoming data against a live node - 2b. Daily aggregation and broadcasting of the finalized transaction - 2d. Automated e2e testing - 3a. Data provisioning using encrypted bundles - *Already reviewed* - 3c. e2e tests that spin up a *single* local server, demonstrating the workflow against a mock GRIN node This pull request does not include: - 2c. Basic reorg protection - 3b. Inter-server communication - 3c. e2e tests that spin up *multiple* local servers, demonstrating the multi-server workflow against a mock GRIN node Sorry about the confusion 😅

The description of the PR lists some deviations from the original project plan. I included much of the milestone 3 work in milestones 1 & 2, but I haven’t yet added reorg support.

Unless there are objections, I would like to push basic reorg support to milestone 3 with the understanding that much of the more complex milestone 3 work was completed earlier. In its current form, the coinswap server should be fully operational, but if a malicious miner is able to reorg a swap transaction out, the server does not attempt to recreate it.

davidtavarez · April 27, 2022, 10:14pm

Are you planning to add tests to the code, right?

scilio · April 28, 2022, 1:21pm

I plan to improve test coverage, but there are tests at the bottom of config.rs, onion.rs, secp.rs, and server.rs.

Cobragrin · June 16, 2022, 6:41pm

Hi @scilio , can we have an update for informing the community ? We are curious and very excited about Coinswap ツ

Grundkurs · September 8, 2022, 6:16am

so what happened to the coinswap implementation? Was anything of value created here or did scilio just pick up the easy parts first and ran a year later into the issue that the hard parts proofed to be impossible to solve for him?

Anynomous · September 8, 2022, 6:47am

The topic was not updated here on the forum, good that you bring it up since both @scilio and the CC forgot to post it here. The discussions were on KeyBase in the CC meetings and on github.

CoinSwap is going well actually. Milestone 1 & 2 were reviewed and approved. All that is left is milestone 3 and a part of the work for this milestone was already done for milestone 2.

Cobragrin · September 8, 2022, 10:27am

Developments regularly took place in newsletters also, since May issue.

Github Tracking for Milestone #3.